Eli Mesika has posted comments on this change. Change subject: setup: Changing task cleaner utility to also handle removal of commands ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/34927/5/packaging/setup/dbutils/taskcleaner.sh File packaging/setup/dbutils/taskcleaner.sh: Line 39: -u USER - The username for the database (def. ${DBFUNC_DB_USER}) Line 40: -d DATABASE - The database name (def. ${DBFUNC_DB_DATABASE}) Line 41: -t TASK_ID - Removes a task by its Task ID. Line 42: -c COMMAND_ID - Removes all tasks related to the given Command Id. Line 43: -T - Removes/Displays all commands that have have running tasks. have have => have Line 44: -o - Removes/Displays all commands. Line 45: -z - Removes/Displays a Zombie task. Line 46: -R - Removes all tasks (use with -z to clear only zombie tasks). Line 47: -r - Removes all commands (use with -T to clear only those with running tasks). Line 239: else Line 240: die "Please specify task" Line 241: fi Line 242: elif [ -n "${CLEAR_COMMANDS}" ]; then Line 243: echo "flag " ${COMMANDS_WITH_RUNNING_TASKS_ONLY} Is this a debug message ???, I think you should remove it Line 244: if [ -n "${COMMANDS_WITH_RUNNING_TASKS_ONLY}" ]; then Line 245: CMD1="SELECT DeleteAllCommandsWithRunningTasks();" Line 246: else Line 247: CMD1="SELECT DeleteAllCommands();" -- To view, visit http://gerrit.ovirt.org/34927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d8f83cb7fc1f7fecb4ea68dff5cf0f3c63eeb6b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
