Martin Peřina has posted comments on this change. Change subject: core: monitoring - Host Monitoring handles Vms Monitoring exeption ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/27922/14/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java: Line 196: if (!vdsReturnValue.getSucceeded()) { Line 197: RuntimeException callException = vdsReturnValue.getExceptionObject(); Line 198: if (callException != null) { Line 199: if (callException instanceof VDSErrorException) { Line 200: log.error("Failed vds listing, vds='{}'({}): {}", vds.getId(), Why did you change the order of log params? Shouldn't there be: log.error("Failed vds listing, vds='{}'({}): {}", vds.getName(), vds.getId(), vdsReturnValue.getExceptionString()); ? Line 201: vds.getName(), vdsReturnValue.getExceptionString()); Line 202: } else if (callException instanceof VDSProtocolException) { Line 203: log.error("Failed vds listing, vds='{}'({}): {}", Line 204: vds.getName(), vds.getId(), vdsReturnValue.getExceptionString()); -- To view, visit http://gerrit.ovirt.org/27922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fb98b6f05fa6f3bb02c59f5217e46c93c3b6875 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
