Martin Peřina has posted comments on this change. Change subject: core: monitoring - make Vm a managed resource ......................................................................
Patch Set 9: (2 comments) http://gerrit.ovirt.org/#/c/32586/9//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-11-10 12:06:06 +0200 Line 6: Line 7: core: monitoring - make Vm a managed resource Line 8: Line 9: - Introduce VmManger state object VmManager Line 10: - responsible for getting dynamic,statistics and saving to db Line 11: - holds the last changed status Line 12: - holds a lock to co-ordinate execution of commands or monitoring Line 13: http://gerrit.ovirt.org/#/c/32586/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java: Line 58: private final Map<Guid, HashSet<Guid>> vdsAndVmsList = new ConcurrentHashMap<>(); Line 59: private final Map<Guid, VdsManager> vdsManagersDict = new ConcurrentHashMap<>(); Line 60: private final Set<Guid> asyncRunningVms = Line 61: Collections.newSetFromMap(new ConcurrentHashMap<Guid, Boolean>()); Line 62: private ConcurrentHashMap<Guid, VmManager> vmManagers = new ConcurrentHashMap<>(); Why not have those initializations in constructor? Line 63: Line 64: private static final String VDSCommandPrefix = "VDSCommand"; Line 65: Line 66: private static final Logger log = LoggerFactory.getLogger(ResourceManager.class); -- To view, visit http://gerrit.ovirt.org/32586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia711cc2d69082ecc03325362291faa4a38aa6c0a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
