Moti Asayag has uploaded a new change for review. Change subject: engine: Rename CommandSuffix to match java standard ......................................................................
engine: Rename CommandSuffix to match java standard Change-Id: Iaa4d4431b721013bb175137af17689802fb9339b Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/77/35077/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java index 7736141..f8be7e2 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java @@ -23,7 +23,7 @@ private static final Logger log = LoggerFactory.getLogger(CommandsFactory.class); private static final Injector injector = new Injector(); private static final String CLASS_NAME_FORMAT = "%1$s.%2$s%3$s"; - private static final String CommandSuffix = "Command"; + private static final String COMMAND_SUFFIX = "Command"; private static final String QUERY_SUFFIX = "Query"; private static final String CTOR_MISMATCH = "could not find matching constructor for Command class {0}"; @@ -82,8 +82,8 @@ private static <P extends VdcActionParametersBase> CommandBase<P> instantiateCommand(VdcActionType action, P parameters, CommandContext commandContext) throws InstantiationException, IllegalAccessException, IllegalArgumentException, InvocationTargetException { return commandContext == null ? - (CommandBase<P>)findCommandConstructor(getCommandClass(action.name(), CommandSuffix), parameters.getClass()).newInstance(parameters) - : (CommandBase<P>) findCommandConstructor(getCommandClass(action.name(), CommandSuffix), + (CommandBase<P>)findCommandConstructor(getCommandClass(action.name(), COMMAND_SUFFIX), parameters.getClass()).newInstance(parameters) + : (CommandBase<P>) findCommandConstructor(getCommandClass(action.name(), COMMAND_SUFFIX), parameters.getClass(), commandContext.getClass()).newInstance(parameters, commandContext); } @@ -146,7 +146,7 @@ } public static Class<CommandBase<? extends VdcActionParametersBase>> getCommandClass(String name) { - return getCommandClass(name, CommandSuffix); + return getCommandClass(name, COMMAND_SUFFIX); } public static Class<CommandBase<? extends VdcActionParametersBase>> getQueryClass(String name) { @@ -154,11 +154,11 @@ } public static <P extends VdcActionParametersBase> boolean hasConstructor(VdcActionType action, P parameters) { - return ReflectionUtils.findConstructor(getCommandClass(action.name(), CommandSuffix), parameters.getClass()) != null; + return ReflectionUtils.findConstructor(getCommandClass(action.name(), COMMAND_SUFFIX), parameters.getClass()) != null; } public static <P extends VdcActionParametersBase> boolean hasConstructor(VdcActionType action, P parameters, CommandContext cmdContext) { - return ReflectionUtils.findConstructor(getCommandClass(action.name(), CommandSuffix), parameters.getClass(), cmdContext.getClass()) != null; + return ReflectionUtils.findConstructor(getCommandClass(action.name(), COMMAND_SUFFIX), parameters.getClass(), cmdContext.getClass()) != null; } private static Class<CommandBase<? extends VdcActionParametersBase>> getCommandClass(String name, String suffix) { -- To view, visit http://gerrit.ovirt.org/35077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaa4d4431b721013bb175137af17689802fb9339b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
