Doron Fediuck has posted comments on this change.
Change subject: core: db function extensions
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File backend/manager/dbscripts/dbfunctions.sh
Line 148: export DATABASE=${DATABASE} SERVERNAME=${SERVERNAME}
PORT=${PORT} USERNAME=${USERNAME}
Eli,
Did you check what happens when DB name includes ';' or '$' or ' " '?
Can you please check if and how quoting is needed?
--
To view, visit http://gerrit.ovirt.org/7021
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6587
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
