Arik Hadas has uploaded a new change for review. Change subject: core: minor cleanup in import vm ......................................................................
core: minor cleanup in import vm Change-Id: Ie27dfe490bcf76aa1425416f1d37524562ac22df Signed-off-by: Arik Hadas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/86/35086/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java index b82ad42..1fcad3f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java @@ -202,8 +202,7 @@ Map<Guid, StorageDomain> domainsMap = new HashMap<Guid, StorageDomain>(); if (getVdsGroup() == null) { - addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CLUSTER_CAN_NOT_BE_EMPTY); - return false; + return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_CLUSTER_CAN_NOT_BE_EMPTY); } if (!canDoActionBeforeCloneVm(domainsMap)) { @@ -214,8 +213,7 @@ initImportClonedVm(); if (getVm().getInterfaces().size() > getMacPool().getAvailableMacsCount()) { - addCanDoActionMessage(VdcBllMessages.MAC_POOL_NOT_ENOUGH_MAC_ADDRESSES); - return false; + return failCanDoAction(VdcBllMessages.MAC_POOL_NOT_ENOUGH_MAC_ADDRESSES); } } -- To view, visit http://gerrit.ovirt.org/35086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie27dfe490bcf76aa1425416f1d37524562ac22df Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
