Alexander Wels has uploaded a new change for review. Change subject: webadmin: Fix exception on VM status column ......................................................................
webadmin: Fix exception on VM status column - When hovering over or clicking on the status column in the VM main tab the console would display an exception. This patch solves that. This is the right status column Change-Id: I1d5cfaa291fe26b1a7439a8a71e8e04d8dc539b0 Signed-off-by: Alexander Wels <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StatusCompositeCellWithElementId.java 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/80/35180/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StatusCompositeCellWithElementId.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StatusCompositeCellWithElementId.java index 3b6931e..b77a4f5 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StatusCompositeCellWithElementId.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StatusCompositeCellWithElementId.java @@ -8,13 +8,14 @@ import com.google.gwt.cell.client.Cell; import com.google.gwt.cell.client.HasCell; import com.google.gwt.core.client.GWT; +import com.google.gwt.dom.client.Element; import com.google.gwt.resources.client.ClientBundle; import com.google.gwt.resources.client.CssResource; import com.google.gwt.safehtml.client.SafeHtmlTemplates; import com.google.gwt.safehtml.shared.SafeHtml; import com.google.gwt.safehtml.shared.SafeHtmlBuilder; -public class StatusCompositeCellWithElementId extends CompositeCellWithElementId<VM> implements CellWithElementId<VM>{ +public class StatusCompositeCellWithElementId extends CompositeCellWithElementId<VM> implements CellWithElementId<VM> { public interface StatusCompositeCellResources extends ClientBundle { @ClientBundle.Source("org/ovirt/engine/ui/common/css/StatusCompositeCell.css") StatusCompositeCellCss statusCompositeCellCss(); @@ -63,11 +64,21 @@ @Override protected <T> void render(Cell.Context context, VM value, - SafeHtmlBuilder sb, HasCell<VM, T> hasCell) { + SafeHtmlBuilder sb, HasCell<VM, T> hasCell) { Cell<T> cell = hasCell.getCell(); if (cell instanceof HasStyleClass) { ((HasStyleClass) cell).setStyleClass(style.divInlineBlock()); } cell.render(context, hasCell.getValue(value), sb); } + + @Override + public boolean isEditing(Context context, Element parent, VM value) { + return false; + } + + @Override + public boolean resetFocus(Context context, Element parent, VM value) { + return false; + } } -- To view, visit http://gerrit.ovirt.org/35180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1d5cfaa291fe26b1a7439a8a71e8e04d8dc539b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
