Hello Tim Speetjens,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/35221
to review the following change.
Change subject: extension-api: fix multiple compiler warnings
......................................................................
extension-api: fix multiple compiler warnings
Fixed warnings related to the use of Class as a raw type.
Fixed unused imports
Change-Id: I0a6c4bb2aff40770607a129a83a20ceb2038dd99
Signed-off-by: Tim Speetjens <[email protected]>
---
M
backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtKey.java
M
backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtUUID.java
M
backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Mapping.java
3 files changed, 6 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/21/35221/1
diff --git
a/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtKey.java
b/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtKey.java
index 977063b..07c1e6e 100644
---
a/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtKey.java
+++
b/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtKey.java
@@ -18,7 +18,7 @@
private static final long serialVersionUID = 7373830750276947742L;
- private transient Class type;
+ private transient Class<?> type;
private String typeName;
private ExtUUID uuid;
private int flags;
@@ -41,7 +41,7 @@
* @param uuid unique identifier for key.
* @param flags key flags see {@link Flags}.
*/
- public ExtKey(Class type, ExtUUID uuid, int flags) {
+ public ExtKey(Class<?> type, ExtUUID uuid, int flags) {
this.type = type;
this.uuid = uuid;
this.flags = flags;
@@ -56,7 +56,7 @@
* @param uuid unique identifier for key.
* @param flags key flags see {@link Flags}.
*/
- public ExtKey(String name, Class type, UUID uuid, int flags) {
+ public ExtKey(String name, Class<?> type, UUID uuid, int flags) {
this(type, new ExtUUID(name, uuid), flags);
}
@@ -67,7 +67,7 @@
* @param uuid unique identifier for key.
* @param flags key flags see {@link Flags}.
*/
- public ExtKey(String name, Class type, String uuid, int flags) {
+ public ExtKey(String name, Class<?> type, String uuid, int flags) {
this(name, type, UUID.fromString(uuid), flags);
}
@@ -77,7 +77,7 @@
* @param type value type.
* @param uuid unique identifier for key.
*/
- public ExtKey(String name, Class type, String uuid) {
+ public ExtKey(String name, Class<?> type, String uuid) {
this(name, type, uuid, 0);
}
@@ -130,7 +130,7 @@
* Returns the type of the key.
* @return Type of key.
*/
- public Class getType() {
+ public Class<?> getType() {
return type;
}
diff --git
a/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtUUID.java
b/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtUUID.java
index ed08b9f..0219349 100644
---
a/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtUUID.java
+++
b/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtUUID.java
@@ -1,8 +1,6 @@
package org.ovirt.engine.api.extensions;
import java.io.Serializable;
-import java.util.HashMap;
-import java.util.Map;
import java.util.UUID;
/**
diff --git
a/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Mapping.java
b/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Mapping.java
index 80f0772..9bb856c 100644
---
a/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Mapping.java
+++
b/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Mapping.java
@@ -1,7 +1,6 @@
package org.ovirt.engine.api.extensions.aaa;
import org.ovirt.engine.api.extensions.ExtKey;
-import org.ovirt.engine.api.extensions.ExtMap;
import org.ovirt.engine.api.extensions.ExtUUID;
/**
--
To view, visit http://gerrit.ovirt.org/35221
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a6c4bb2aff40770607a129a83a20ceb2038dd99
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Tim Speetjens <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches