Yaniv Bronhaim has posted comments on this change. Change subject: ui: fixing addHost form issues when playing with using host provider ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/35239/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java: Line 1864 Line 1865 Line 1866 Line 1867 Line 1868 we don't need it. setting those fields just trigger other listener and it confuses everything http://gerrit.ovirt.org/#/c/35239/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java: Line 83 Line 84 Line 85 Line 86 Line 87 moved it from here. setting is once when choosing to use provider http://gerrit.ovirt.org/#/c/35239/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java: Line 751: if (Boolean.TRUE.equals(object.getIsDiscoveredHosts().getEntity())) { Line 752: rbDiscoveredHost.setValue(true); Line 753: showDiscoveredHostsWidgets(true); Line 754: object.cleanHostParametersFields(); Line 755: } else if (Boolean.FALSE.equals(object.getIsDiscoveredHosts().getEntity())) { this fixing a bug as it was called when getIsSicoveredHosts was set to null. therefore the widget still appeared. Line 756: rbProvisionedHost.setValue(true); Line 757: showProvisionedHostsWidgets(true); Line 758: object.cleanHostParametersFields(); Line 759: } -- To view, visit http://gerrit.ovirt.org/35239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I700ec281a1bd1617d0168d59c8daef5b5bcf4f6b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
