Oved Ourfali has posted comments on this change. Change subject: Allow registerVds with same name and hostname if provisioned ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/35207/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java: Line 194: // approve command action after registration Line 195: RefObject<Boolean> isPending = new RefObject<Boolean>(Boolean.FALSE); Line 196: getQueryReturnValue().setSucceeded( Line 197: HandleOldVdssWithSameHostName(vdsByUniqueId) && HandleOldVdssWithSameName(vdsByUniqueId) Line 198: && CheckAutoApprovalDefinitions(isPending) what about this check? Isn't it needed for provisioned host? (the check auto approval definitions). Line 199: && Register(vdsByUniqueId, vdsGroupId, isPending.argvalue.booleanValue())); Line 200: } Line 201: log.debug("RegisterVdsQuery::ExecuteCommand - Leaving Succeded value is '{}'", Line 202: getQueryReturnValue().getSucceeded()); -- To view, visit http://gerrit.ovirt.org/35207 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I157b567b2c868b12a89a394e909e97895338380d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
