Piotr Kliczewski has uploaded a new change for review. Change subject: core: mapParams performance improvement ......................................................................
core: mapParams performance improvement When going through jprofiler snapshots from scale env I noticed that getDataTimeInstance is taking a lot of time. DateFormat objects is not used but we create it every time we run mapParams so we can remove it without any harm. Change-Id: Ib914112be17442e13148def922a486ccf9c0f63f Signed-off-by: pkliczewski <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/BatchProcedureExecutionConnectionCallback.java 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/87/35287/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/BatchProcedureExecutionConnectionCallback.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/BatchProcedureExecutionConnectionCallback.java index 1c352a7..0f7e27e 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/BatchProcedureExecutionConnectionCallback.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/BatchProcedureExecutionConnectionCallback.java @@ -9,8 +9,6 @@ import java.sql.SQLException; import java.sql.Timestamp; import java.sql.Types; -import java.text.DateFormat; -import java.text.SimpleDateFormat; import java.util.Date; import java.util.HashMap; import java.util.List; @@ -164,7 +162,6 @@ Map<String, Object> values = paramSource.getValues(); for (Map.Entry<String, SqlCallParameter> paramOrderEntry : paramOrder.entrySet()) { - DateFormat sdf = SimpleDateFormat.getDateTimeInstance(); String paramName = paramOrderEntry.getKey(); Object value = values.get(paramName); if (value == null && paramName.startsWith(DbFacade.getInstance().getDbEngineDialect().getParamNamePrefix())) { -- To view, visit http://gerrit.ovirt.org/35287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib914112be17442e13148def922a486ccf9c0f63f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
