Tal Nisan has submitted this change and it was merged. Change subject: Revert "core: Store iSCSI Target Address instead of IP Address in DB" ......................................................................
Revert "core: Store iSCSI Target Address instead of IP Address in DB" This reverts commit c6c9bdb239042ca0ab4543d154d5144740ba4379. The idea of working with the original address we get from the user instead of the IP address we get from VDSM works fine in case that the iscsi server has only one NIC. When it has more than one (Multipath, for example) the VDSM sends all the addresses it discovered, and we override all of them with the original address we got from the user. This makes the login to all of the other targets fail (except for the first one). Thus, working with the original address is not possible. Change-Id: I3974820e9039f05aa716752330c1b2ec13591137 Signed-off-by: Idan Shaby <[email protected]> Bug-Url: https://bugzilla.redhat.com/1163948 --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DiscoverSendTargetsVDSCommand.java 1 file changed, 1 insertion(+), 11 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Idan Shaby: Verified Objections: Nir Soffer: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/35295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3974820e9039f05aa716752330c1b2ec13591137 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
