Sahina Bose has posted comments on this change. Change subject: bll: stop and delete geo-rep session ......................................................................
Patch Set 8: (5 comments) Patchset to follow http://gerrit.ovirt.org/#/c/33038/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGeoRepSessionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGeoRepSessionCommand.java: Line 26: } Line 27: Line 28: @Override Line 29: protected void setActionMessageParameters() { Line 30: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__REMOVE); > See previous comment on multiple addCanDoActionMessage Will do.. Line 31: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__GLUSTER_GEOREP_SESSION); Line 32: addCanDoActionMessageVariable("volumeName", getGlusterVolumeName()); Line 33: addCanDoActionMessageVariable("vdsGroup", getVdsGroupName()); Line 34: } Line 45: if (getSucceeded()) { Line 46: getGlusterGeoRepDao().remove(getGeoRepSession().getId()); Line 47: } else { Line 48: handleVdsError(AuditLogType.GEOREP_SESSION_DELETE_FAILED, returnValue.getVdsError().getMessage()); Line 49: return; > why do we need this return here? Not needed. Will change Line 50: } Line 51: } Line 52: Line 53: @Override http://gerrit.ovirt.org/#/c/33038/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGeoRepSessionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGeoRepSessionCommand.java: Line 58: getGeoRepSession().setStatus(GeoRepSessionStatus.STOPPED); Line 59: getGlusterGeoRepDao().updateSession(getGeoRepSession()); Line 60: } else { Line 61: handleVdsError(AuditLogType.GEOREP_SESSION_STOP_FAILED, returnValue.getVdsError().getMessage()); Line 62: return; > same return question as before Not required. Changing Line 63: } Line 64: } Line 65: Line 66: @Override http://gerrit.ovirt.org/#/c/33038/8/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java: Line 437: Line 438: String VdcActionType___RecoveryStoragePool(); Line 439: Line 440: String VdcActionType___UpdateVmInterface(); Line 441: > Please add corresponding entries for vdcActionType here Done Line 442: String VdcActionType___MigrateVmToServer(); Line 443: Line 444: String VdcActionType___UpdateDisplayToVdsGroup(); Line 445: http://gerrit.ovirt.org/#/c/33038/8/frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties File frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties: Line 220: Line 221: VdcActionType___ActivateVds=Activate Host Line 222: VdcActionType___RecoveryStoragePool=Reinitialize Data Center Line 223: VdcActionType___UpdateVmInterface=Edit VM Interface properties Line 224: VdcActionType___MigrateVmToServer=Migrate VM to a specific Host > Please add corresponding entries for vdcActionType here Done Line 225: VdcActionType___UpdateDisplayToVdsGroup=Set Logical Network for Display Protocol Line 226: VdcActionType___ChangeDisk=Change CD Line 227: VdcActionType___ShutdownVm=Shutdown VM Line 228: VdcActionType___ApproveVds=Approve Host -- To view, visit http://gerrit.ovirt.org/33038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I537a11bde7c412599a00269d44764f554bb4618d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
