Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Entities for gluster volume snapshot ......................................................................
Patch Set 12: (3 comments) http://gerrit.ovirt.org/#/c/23199/12/packaging/dbscripts/upgrade/03_06_0480_add_gluster_volume_snapshot_tables.sql File packaging/dbscripts/upgrade/03_06_0480_add_gluster_volume_snapshot_tables.sql: Line 1: -- Add gluster_volume_snapshots table Line 2: CREATE TABLE gluster_volume_snapshots Line 3: ( Line 4: snapshot_id UUID NOT NULL, Line 5: cluster_id UUID NOT NULL, > cluster_id not required here. as volume table will have this detail and the As discussed will try to use views and have volume_id only here Line 6: volume_id UUID NOT NULL, Line 7: snapshot_name VARCHAR(1000) NOT NULL, Line 8: created_at TIMESTAMP WITH TIME ZONE, Line 9: description VARCHAR(1024), Line 7: snapshot_name VARCHAR(1000) NOT NULL, Line 8: created_at TIMESTAMP WITH TIME ZONE, Line 9: description VARCHAR(1024), Line 10: status VARCHAR(32), Line 11: _create_date TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT LOCALTIMESTAMP, > what's the difference between created_at and create_date? Not necessary here. Gluster has a field associated with snapshot so thought of keeping here. Line 12: _update_date TIMESTAMP WITH TIME ZONE, Line 13: CONSTRAINT pk_snapshot_id PRIMARY KEY(snapshot_id) Line 14: ) WITH OIDS; Line 15: Line 16: -- Add gluster_volume_snapshot_config table Line 17: CREATE TABLE gluster_volume_snapshot_config Line 18: ( Line 19: cluster_id UUID NOT NULL, Line 20: entity_id UUID NOT NULL, > won't entity_id be null in case of cluster-wide snapshot config? Following patch makes it nullable and FK introduced. Line 21: param_name VARCHAR(128) NOT NULL, Line 22: param_value VARCHAR(128) Line 23: ) WITH OIDS; Line 24: CREATE UNIQUE INDEX IDX_gluster_volume_snapshot_config_unique ON gluster_volume_snapshot_config(cluster_id, entity_id, param_name); -- To view, visit http://gerrit.ovirt.org/23199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idafc74e193fd0d957ee134b53231d99c4ab2e9d8 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Nishanth Thomas <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
