Shahar Havivi has posted comments on this change. Change subject: core: Avoid too many IDE or sPAPR VSCSI devices ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/34764/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java: Line 904: if (!checkRngDeviceClusterCompatibility()) { Line 905: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_RNG_SOURCE_NOT_SUPPORTED); Line 906: } Line 907: Line 908: boolean isWindowsOs = SimpleDependecyInjector.getInstance().get(OsRepository.class).isWindows(getVm().getVmOsId()); Please use: OsRepositoryImpl.INSTANCE.isWindows(getVm().getVmOsId()) Line 909: Line 910: boolean isCloudInitEnabled = (!getVm().isInitialized() && hasVmInit() && !isWindowsOs) || Line 911: (getParameters().getInitializationType() == InitializationType.CloudInit); Line 912: Line 909: Line 910: boolean isCloudInitEnabled = (!getVm().isInitialized() && hasVmInit() && !isWindowsOs) || Line 911: (getParameters().getInitializationType() == InitializationType.CloudInit); Line 912: Line 913: if ((getVm().getVmPayload() != null || isCloudInitEnabled) && hasMaximumNumberOfDisks()) { 1. Payload can be floppy 2. We are handling the same condition and falling with canDoAction in line #925 Line 914: return failCanDoAction(VdcBllMessages.VMPAYLOAD_CDROM_OR_CLOUD_INIT_MAXIMUM_DEVICES); Line 915: } Line 916: Line 917: // Note: that we are setting the payload from database in the ctor. -- To view, visit http://gerrit.ovirt.org/34764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86eee7c084d0278a8ee5b1d56612104db3a409ee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
