Yair Zaslavsky has uploaded a new change for review. Change subject: aaa: exceptions should be propagated in builtin ldap provider ......................................................................
aaa: exceptions should be propagated in builtin ldap provider All exceptions which are caught during the privileged action execution should be propagated and not swollowed. In addition, NegativeArraySizeException is handled as a severe exception, meaning there will be no attempt to try the next server if is caught Change-Id: Iafa1dcf67545e81a14981bb3c33e52a570684d72 Topic: AAA Signed-off-by: Yair Zaslavsky <[email protected]> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LDAPTemplateWrapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchExceptionHandler.java 2 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/39/35339/1 diff --git a/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LDAPTemplateWrapper.java b/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LDAPTemplateWrapper.java index 330f7e7..d801679 100644 --- a/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LDAPTemplateWrapper.java +++ b/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LDAPTemplateWrapper.java @@ -149,7 +149,8 @@ private Throwable handleException(Exception e) { if (e instanceof RuntimeException) { throw (RuntimeException) e; + } else { + throw new RuntimeException(e); } - return e; } } diff --git a/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchExceptionHandler.java b/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchExceptionHandler.java index 96466d6..ecf31bf 100644 --- a/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchExceptionHandler.java +++ b/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchExceptionHandler.java @@ -25,6 +25,8 @@ handleEngineDirectoryServiceException(response, e); } else if (e instanceof AuthenticationException) { handleAuthenticationException(response); + } else if (e instanceof NegativeArraySizeException) { + handleAuthenticationException(response); } else if (e instanceof CommunicationException) { handleCommunicationException(response, e); } else if (e instanceof InterruptedException) { -- To view, visit http://gerrit.ovirt.org/35339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iafa1dcf67545e81a14981bb3c33e52a570684d72 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
