Omer Frenkel has posted comments on this change. Change subject: engine: Change DisplayType semantics ......................................................................
Patch Set 35: (1 comment) just one comment for the backend, still need ack for rest and ui parts http://gerrit.ovirt.org/#/c/30837/35/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java: Line 297: * Line 298: * @param srcEntityId - guid of template/base VM Line 299: * @return Line 300: */ Line 301: protected Set<GraphicsType> getResultingVmGraphics(Guid sourceId) { if this is exactly the same code as in VmManagementCommandBase, it should be extracted to some helper class (could be static in vmHandler) Line 302: Set<GraphicsType> sourceGraphics = new HashSet<>(); Line 303: Set<GraphicsType> paramGraphics = getParameters().graphicsTypesToBeSet(); Line 304: Set<GraphicsType> result = new HashSet<>(); Line 305: -- To view, visit http://gerrit.ovirt.org/30837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0907c9086f49f909250d9956356a0251954f1427 Gerrit-PatchSet: 35 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
