Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: better handling of preexisting storage domain
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/35351/1/src/plugins/ovirt-hosted-engine-setup/storage/storage.py
File src/plugins/ovirt-hosted-engine-setup/storage/storage.py:

Line 387:     def _validateStorageDomain(self, sdUUID):
Line 388:         self.logger.debug('validateStorageDomain')
Line 389:         response = self.serv.s.validateStorageDomain(sdUUID)
Line 390:         self.logger.debug(response)
Line 391:         if response['status']['code']:
response['status']['code'] == 0
Line 392:             return response['status']['code'], 
response['status']['message']
Line 393:         return 0, ''
Line 394: 
Line 395:     def _getStorageDomainInfo(self, sdUUID):


-- 
To view, visit http://gerrit.ovirt.org/35351
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I622e0540ca21eea5ebddbfa4361bfb6537ca42d8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to