Alon Bar-Lev has posted comments on this change. Change subject: packaging: enable build validation as default ......................................................................
Patch Set 1: > rpmbuild -D "buildvalidation 1" this is fine as I wrote, however, you should also add required dependencies in this case. I do not think that spec is the right place for build validation... no need to build rpm to achieve that goal, you can simply execute the build directly. spec/rpm are for release distribution, there are better more effient ways to automate this. -- To view, visit http://gerrit.ovirt.org/35321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d83c1914f151788d3af34b29bea85f5c3492b10 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
