Maor Lipchuk has posted comments on this change. Change subject: core:Add connection to DB after connectVds(#815083) ......................................................................
Patch Set 2: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java Line 34: isValidConnection = isValidConnection && Connect(vds.getId()).getFirst(); agree, In second look I will change this code to return true (instead false) if one connection succeeded. Line 112 I looks like we compare the parameter connection with it self, will be removed. -- To view, visit http://gerrit.ovirt.org/3784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e1387295f4c24f4222b57924ec2f4380411c5f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
