Maor Lipchuk has posted comments on this change. Change subject: core: Add Video managed device for VM's/Template's OVF. ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/34734/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java: Line 508: List<VmDevice> devices = Line 509: DbFacade.getInstance() Line 510: .getVmDeviceDao() Line 511: .getVmDeviceByVmIdAndType(vmBase.getId(), VmDeviceGeneralType.VIDEO); Line 512: for (VmDevice device : devices) { > please replace this method with code in Entities, there's no reason for thi There is no need to do so, it is not related to the patch Line 513: managedDeviceMap.put(device.getDeviceId(), device); Line 514: } Line 515: } Line 516: -- To view, visit http://gerrit.ovirt.org/34734 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5583edadd75bce7dfb3f5ba04cfcbe38f1dc7091 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
