Arik Hadas has posted comments on this change. Change subject: core: UnlockImage should be run in new transaction ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35419/1//COMMIT_MSG Commit Message: Line 8: Line 9: As "endAction" is run in suspeneed mode in most cases, Line 10: and unlock image is a short db operation - it is better Line 11: to run the unlock image in a new transaction (no compensation is required, as Line 12: this is endAction). it is not clear to me what is the problem that you try to solve if the interesting case is where endAction is executed in suspended mode and you are doing 1 update in the DB to change the image status - how does the transaction help us? Line 13: Line 14: Change-Id: Iddb031f18023db8fab6c1ab7f07cef9942238de2 -- To view, visit http://gerrit.ovirt.org/35419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddb031f18023db8fab6c1ab7f07cef9942238de2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
