Juan Hernandez has posted comments on this change.

Change subject: RFE: Add Granular permissions for VM operations
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/35206/6/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java
File 
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java:

Line 21
Line 22
Line 23
Line 24
Line 25
> Juan,
Mark it as @Deprecated in the code:

  /**
   * @deprecated This has been replaced by blah, blah, blah
   */
  @Deprecated
  VM_BASIC_OPERATIONS

This will alert developers, but not users. For users the only way is to 
document it with a release note.


-- 
To view, visit http://gerrit.ovirt.org/35206
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ae2d6ad2ebc6c8e0948abe1c413362f4e3dbda7
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to