Shubhendu Tripathi has uploaded a new change for review. Change subject: webadmin: Maximum no of snapshots in general subtab ......................................................................
webadmin: Maximum no of snapshots in general subtab Introduced a new field to list the maximum no of snapshots for a volume under the General sub tab of Volumes tab. Change-Id: Ia6733e82f0e6ccaaee54aac959aa0969430d4016 Signed-off-by: Shubhendu Tripathi <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java 3 files changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/77/35477/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java index d341419..02ca742 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java @@ -19,6 +19,7 @@ private String glusterMountPoint; private String nfsMountPoint; private Set<TransportType> transportTypes; + private String snapMaxLimit; public String getName() { return name; @@ -89,6 +90,14 @@ this.nfsMountPoint = nfsMountPoint; } + public String getSnapMaxLimit() { + return this.snapMaxLimit; + } + + public void setSnapMaxLimit(String noOfSnaps) { + this.snapMaxLimit = noOfSnaps; + } + public VolumeGeneralModel() { setTitle(ConstantsManager.getInstance().getConstants().generalTitle()); setHelpTag(HelpTag.general); @@ -113,6 +122,7 @@ setStripeCount(entity.getStripeCount() != null ? Integer.toString(entity.getStripeCount()) : null); setNumOfBricks(entity.getBricks() != null ? Integer.toString(entity.getBricks().size()) : null); setTransportTypes(entity.getTransportTypes()); + setSnapMaxLimit(entity.getSnapMaxLimit() != null ? entity.getSnapMaxLimit().toString() : null); } public Set<TransportType> getTransportTypes() { diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java index 086ed52..b0fff13 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java @@ -2807,6 +2807,9 @@ @DefaultStringValue("Transport Types") String transportTypesVolume(); + @DefaultStringValue("Maximum no of snapshots") + String maxNumberOfSnapshotsVolume(); + @DefaultStringValue("Activities") String activitiesOnVolume(); diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java index fa13fd2..6dab04b 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java @@ -45,6 +45,7 @@ TextBoxLabel stripeCount = new TextBoxLabel(); TextBoxLabel numOfBricks = new TextBoxLabel(); VolumeTransportTypeLabel transportTypes = new VolumeTransportTypeLabel(); + TextBoxLabel snapMaxLimit = new TextBoxLabel(); FormBuilder formBuilder; @@ -64,7 +65,7 @@ driver.initialize(this); // Build a form using the FormBuilder - formBuilder = new FormBuilder(formPanel, 1, 7); + formBuilder = new FormBuilder(formPanel, 1, 8); formBuilder.addFormItem(new FormItem(constants.NameVolume(), name, 0, 0)); formBuilder.addFormItem(new FormItem(constants.volumeIdVolume(), volumeId, 1, 0)); @@ -79,6 +80,8 @@ formBuilder.addFormItem(new FormItem(constants.numberOfBricksVolume(), numOfBricks, 5, 0)); formBuilder.addFormItem(new FormItem(constants.transportTypesVolume(), transportTypes, 6, 0)); + formBuilder.addFormItem(new FormItem(constants.maxNumberOfSnapshotsVolume(), snapMaxLimit, 7, 0)); + getDetailModel().getPropertyChangedEvent().addListener(new IEventListener<PropertyChangedEventArgs>() { @Override public void eventRaised(Event<? extends PropertyChangedEventArgs> ev, Object sender, PropertyChangedEventArgs args) { -- To view, visit http://gerrit.ovirt.org/35477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia6733e82f0e6ccaaee54aac959aa0969430d4016 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
