Omer Frenkel has posted comments on this change. Change subject: core: change import vm to be VmCommand - part 2 ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/34986/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java: Line 1175: iface.setVmTemplateId(null); Line 1176: iface.setVmId(getVmId()); Line 1177: } Line 1178: Line 1179: protected void fillMacAddressIfMissing(VmNic iface) { is it shared? or going to be? if not, probably need to be private Line 1180: if (StringUtils.isEmpty(iface.getMacAddress()) Line 1181: && getMacPool().getAvailableMacsCount() > 0) { Line 1182: iface.setMacAddress(getMacPool().allocateNewMac()); Line 1183: } -- To view, visit http://gerrit.ovirt.org/34986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7063d22fbe4bd81de24f050660e35b3ea7b96cd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
