Moti Asayag has posted comments on this change. Change subject: engine: Added Quartz clean up listener ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/14543/2/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/CleanUpThreadJobListener.java File backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/CleanUpThreadJobListener.java: Line 25: } Line 26: Line 27: @Override Line 28: public void jobWasExecuted(JobExecutionContext context, JobExecutionException jobException) { Line 29: ThreadLocalParamsContainer.clean(); > Does not exist any more. +1, since the essence of this patch is to clearing threads which their ThreadLocal was manipulated, and due to a recent effort to remove any dependency on ThreadLocal, it is safe to abandon this patch. Line 30: } -- To view, visit http://gerrit.ovirt.org/14543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97dcf3797853469411173602f8eb64ef0b05d35d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
