Martin Mucha has posted comments on this change. Change subject: core: do not fail when there's no mac in pool on engine startup. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35392/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerRanges.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerRanges.java: Line 71 Line 72 Line 73 Line 74 Line 75 > having n+1 messages is bad. good, that would stop the flood. But should there be flood to be stopped in first place? I think no, there should not. Question: do you think, there should be complaint about empty pool when I'm adding MAC out of mac pool, or MAC regardless whether it's used? -- To view, visit http://gerrit.ovirt.org/35392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc486d04748d3a49291746c57955db2aaae2f389 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
