Martin Pavlásek has posted comments on this change. Change subject: Separate constants from rules to collector, read it from XML ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34688/1/mom/Collectors/GuestMemory.py File mom/Collectors/GuestMemory.py: Line 29: hypervisor isn't able to provide its own values. Line 30: """ Line 31: return {'min_guest_free_percent': 0.2, Line 32: 'max_balloon_change_percent': 0.05, Line 33: 'min_balloon_change_percent': 0.0025} > I agree with Adam. I would create another collector (CustomGuestBalooning o Hi folks, I'm sorry, I didn't check out ovrit's review for quite long time :-( I was working on other stuff. I like idea with GuestConstats, it's much better/clear than my hard-coded values. Line 34: Line 35: def getFields(self): Line 36: fields = self.hypervisor_iface.getStatsFields() Line 37: fields.update(self.getConstants().keys()) -- To view, visit http://gerrit.ovirt.org/34688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c16d29f6e1d541808d9c1f4051c3de0cc746098 Gerrit-PatchSet: 1 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Pavlásek <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Martin Pavlásek <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
