Oved Ourfali has posted comments on this change. Change subject: foreman-integration: Remove domain from hostname to allow rhevh registration ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35450/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java: Line 156: // force to reload vdss by unique ID used later on Line 157: _vdssByUniqueId = null; Line 158: VDS vdsByUniqueId = getVdssByUniqueId().size() != 0 ? getVdssByUniqueId().get(0) : null; Line 159: String registeredVdsName = getParameters().getVdsName().split("\\.")[0]; Line 160: VDS provisionedVds = DbFacade.getInstance().getVdsDao().getByName(registeredVdsName); > 1. as i said before - the registration call comes from node with hostname== Not sure I follow. it always brings IP address? Or either FQDN or IP? Let's talk face-to-face tomorrow Line 161: if (provisionedVds != null && provisionedVds.getStatus() != VDSStatus.InstallingOS) { Line 162: // if not in InstallingOS status, this host is not provisioned. Line 163: provisionedVds = null; Line 164: } -- To view, visit http://gerrit.ovirt.org/35450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c258def25d2e484d4094784eb0b15d62c7ef3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
