Yedidyah Bar David has posted comments on this change.

Change subject: core: Allow returning different return codes
......................................................................


Patch Set 3:

On Mar 25, 2014 Alon wrote:

> what if two plugins compete on exit code? this creates scalar dependency.

> Probably better to throw a special exception in this case which has a 
> property of exit code.

Now Alon wrote:

> I do not like the use of exception as it does not allow us to exit code in 
> case of success. will think on it a bit more.

Not sure we really need to have to be able to return != 0 on success. It's 
quite rare to do that in unix. I don't object strongly, though - just tell me 
what you want.

-- 
To view, visit http://gerrit.ovirt.org/26062
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56e6077f28b876d5358441654a2bedb7330fdd42
Gerrit-PatchSet: 3
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to