Doron Fediuck has posted comments on this change.
Change subject: bootstrap: send firewall rules without creating temp file
......................................................................
Patch Set 4: (1 inline comment)
one minor issue.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java
Line 330: }
Line 331: }
Line 332: }
Line 333:
Line 334: private boolean uploadString(String str, String remote) {
Is it possible to get a better name for this method?
Indeed it uploads a string, but into what?
Can dumpStringToRemoteFile be used? any other suggestion?
Line 335: boolean isUploaded = false;
Line 336:
Line 337: try {
Line 338: _wrapper.executeCommand(
--
To view, visit http://gerrit.ovirt.org/7028
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61b0ee4c62382807d14c5476baf2898a08ee5892
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
