Allon Mureinik has posted comments on this change.
Change subject: core:Print clusters when upgrading DC version(#844425)
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
Minor issues, see inline.
+3 for actually writing a unit test.
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java
Line 133: assertFalse(cmd.checkAllClustersLevel());
Line 134: List<String> messages =
cmd.getReturnValue().getCanDoActionMessages();
Line 135:
assertTrue(messages.contains(VdcBllMessages.ERROR_CANNOT_UPDATE_STORAGE_POOL_COMPATIBILITY_VERSION_BIGGER_THAN_CLUSTERS.toString()));
Line 136: assertTrue(messages.get(0).contains("firstCluster"));
Line 137: assertTrue(!messages.get(0).contains("secondCluster"));
use assertFalse instead of assertTrue with "!" at the begining - it's
unreadable.
Line 138: assertTrue(messages.get(0).contains("thirdCluster"));
Line 139: }
Line 140:
Line 141: @Test
....................................................
Commit Message
Line 8:
Line 9: https://bugzilla.redhat.com/show_bug.cgi?id=844425
Line 10:
Line 11: When we upgrade Data-Center we check if all cluster also has a validate
Line 12: level (which is the same as the DC or upper), if not, user gets a
s/upper/higher/
s/user/the user/
Line 13: message that it should upgrade the clusters, but there are no mentions
Line 14: which clusters it should be upgraded.
Line 15:
Line 16: The proposed fix, adds the cluster names that should be upgraded to the
Line 9: https://bugzilla.redhat.com/show_bug.cgi?id=844425
Line 10:
Line 11: When we upgrade Data-Center we check if all cluster also has a validate
Line 12: level (which is the same as the DC or upper), if not, user gets a
Line 13: message that it should upgrade the clusters, but there are no mentions
s/it/he/
s/mentions/mention/
Line 14: which clusters it should be upgraded.
Line 15:
Line 16: The proposed fix, adds the cluster names that should be upgraded to the
Line 17: message, and add a test to cover it.
--
To view, visit http://gerrit.ovirt.org/7132
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9c92d1c477354f7f5fa66895ecf2ab38c10bdf6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
