Sandro Bonazzola has posted comments on this change. Change subject: Doing proper mock cleanup ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/35597/2/jobs/confs/shell-scripts/mock_cleanup.sh File jobs/confs/shell-scripts/mock_cleanup.sh: Line 13: failed=false Line 14: mounts=($(mount | awk '{print $3}' | grep "$mock_dir")) || : Line 15: if [[ "$mounts" ]]; then Line 16: echo "Found mounted dirs inside the chroot. Trying to umount." Line 17: fi doesn't "mock --clean" take care of unmounting and cleaning up the chroot? Line 18: for mount in "${mounts[@]}"; do Line 19: umount "$mount" \ Line 20: || { Line 21: echo "ERROR: Failed to umount $mount. Aborting." -- To view, visit http://gerrit.ovirt.org/35597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20cb54fb968556f3d1bdcf3a9ab14e826c56b352 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <[email protected]> Gerrit-Reviewer: Barak Korren <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Paz Dangur <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Sharon Naftaly <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
