Sharad Mishra has posted comments on this change.
Change subject: core: ReconstructMasterDomain - refresh storage pool before
connect(#841525)
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
Line 223: returnValue =
executeRefreshStoragePoolCommand(vds);
Line 224: if (!returnValue.getSucceeded()) {
Line 225: log.errorFormat("Post reconstruct actions
(refreshPool) did not complete on host {0} in the pool. error {1}",
Line 226: vds.getId(),
Line 227:
returnValue.getVdsError().getMessage());
should we keep executing the loop or skip the current iteration by adding
'continue' here?
Line 228: }
Line 229: }
Line 230: // the host that executed the reconstruct command
doesn't perform refresh
Line 231: // so even if refresh command wasn't executed in
the loop (returnValue == null), we need to
--
To view, visit http://gerrit.ovirt.org/7137
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b1b6c32ecb1c0d3c0a9ef14beef333e442c6ccf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
