Juan Hernandez has posted comments on this change.
Change subject: packaging: Do not allow whitespaces in passwords (#BZ835363)
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File packaging/fedora/setup/engine_validators.py
Line 156: def validatePassword(param, options=[]):
Line 157: logging.debug("Validating password")
Line 158: if not validateStringNotEmpty(param, options):
Line 159: return False
Line 160: if ' ' in param:
What about tabs or other white spaces? I would suggest this:
if re.search("\s", param):
...
Line 161: logging.warn(output_messages.WARN_SPACES_IN_PASS)
Line 162: print output_messages.WARN_SPACES_IN_PASS
Line 163: return False
Line 164: try:
--
To view, visit http://gerrit.ovirt.org/7033
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia29fb22c53f45d735f1d722ae9a80e5ccbb2246b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
