Omer Frenkel has posted comments on this change.
Change subject: core: add message when no host with network found on run vm
......................................................................
Patch Set 1: (2 inline comments)
yes its missing, will send another patch with all fixes
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java
Line 326:
Line 327: return readyToRun.isEmpty() ? Guid.Empty :
getBestVdsToRun(readyToRun);
Line 328: }
Line 329:
Line 330: boolean areRequiredNetworksAvailable(final
List<VdsNetworkInterface> allInterfacesForVds) {
Done
Line 331: for (final VmNetworkInterface vmIf : getVmNICs()) {
Line 332: boolean found = false;
Line 333: for (final VdsNetworkInterface vdsIf :
allInterfacesForVds) {
Line 334: if (StringUtils.equals(vmIf.getNetworkName(),
vdsIf.getNetworkName())) {
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 168: ACTION_TYPE_FAILED_INVALID_CUSTOM_VM_PROPERTIES_INVALID_VALUES=Cannot
${action} ${type} if some of the specified custom properties have illegal
values. The keys are: ${WrongValueKeys}
Line 169: ACTION_TYPE_FAILED_VDS_VM_CLUSTER=Cannot ${action} ${type}. There are
no available running Hosts in the Host Cluster.
Line 170: ACTION_TYPE_FAILED_VDS_VM_MEMORY=Cannot ${action} ${type}. There are
no available running Hosts with sufficient memory in VM's Cluster .
Line 171: ACTION_TYPE_FAILED_VDS_VM_CPUS=Cannot ${action} ${type}. There are no
available running Hosts with enough cores in VM's Cluster .
Line 172: ACTION_TYPE_FAILED_VDS_VM_NETWORKS=Cannot ${action} ${type}. There
are no available running Hosts with all the networks used by the VM.
Done
Line 173: CANNOT_MAINTANANCE_VDS_RUN_VMS_NO_OTHER_RUNNING_VDS=The following
Hosts have running VMs and cannot be switched to maintenance mode: ${HostsList}.
Line 174: Please ensure that the following Clusters have at least one Host in
UP state: ${ClustersList}.
Line 175: ACTION_TYPE_FAILED_VDS_VM_VERSION=Cannot ${action} ${type}. VM's
tools version (${toolsVersion}) mismatch with the Host's (${serverVersion})
version.
Line 176: ACTION_TYPE_FAILED_VDS_VM_SWAP=Cannot ${action} ${type}. Host swap
percentage is above the defined threshold.\n\
--
To view, visit http://gerrit.ovirt.org/7130
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f4066b80f0ec7db0b640fc818f833fdb387fdf8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
