Arik Hadas has uploaded a new change for review. Change subject: core: rename RunVmCommandBase#processVmPoolOnStopVm ......................................................................
core: rename RunVmCommandBase#processVmPoolOnStopVm This method handles not only VMs from pool, but every VM that went down. Thus, its name is changed to processVmOnDown Change-Id: Ide45cda8a4fa5bb989d1a9eb8408717a9b071860 Signed-off-by: Arik Hadas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/28/35928/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java index 63ab11c..2cab084 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java @@ -98,11 +98,11 @@ } @Override - protected void processVmPoolOnStopVm() { + protected void processVmOnDown() { // In case the migration failed and the VM turned back to Up in the // source, we don't need to handle it as a VM that failed to run if (getVm().getStatus() != VMStatus.Up) { - super.processVmPoolOnStopVm(); + super.processVmOnDown(); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java index e5ae147..1944fe7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java @@ -144,7 +144,7 @@ _isRerun = false; setSucceeded(false); log(); - processVmPoolOnStopVm(); + processVmOnDown(); ExecutionHandler.setAsyncJob(getExecutionContext(), false); ExecutionHandler.endJob(getExecutionContext(), false); } @@ -153,7 +153,7 @@ } } - protected void processVmPoolOnStopVm() { + protected void processVmOnDown() { ThreadPoolUtil.execute(new Runnable() { @Override public void run() { -- To view, visit http://gerrit.ovirt.org/35928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ide45cda8a4fa5bb989d1a9eb8408717a9b071860 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
