Maor Lipchuk has posted comments on this change. Change subject: core: Increment DB Generation when image is copied ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/35932/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java: Line 268: Line 269: @Override Line 270: protected void endSuccessfully() { Line 271: endCommandActions(); Line 272: incrementDbGenerationForRelatedEntities(); > Why aren't we doing it also on endWithFailure() ? There are no changes with endwithFailure Line 273: } Line 274: Line 275: private void incrementDbGenerationForRelatedEntities() { Line 276: if (getParameters().getOperation() == ImageOperation.Copy) { -- To view, visit http://gerrit.ovirt.org/35932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdd5e02387fe729195bd4b3c502636671a914e5d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
