Arik Hadas has posted comments on this change. Change subject: core: Graphics Device CRUD ......................................................................
Patch Set 19: (3 comments) minor comments http://gerrit.ovirt.org/#/c/25409/19/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GraphicsParameters.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GraphicsParameters.java: Line 4: import org.ovirt.engine.core.common.businessentities.GraphicsDevice; Line 5: Line 6: public class GraphicsParameters extends VdcActionParametersBase { Line 7: Line 8: private boolean isVm = true; s/isVm/vm/g Line 9: private GraphicsDevice dev; Line 10: Line 11: public GraphicsParameters(GraphicsDevice dev) { Line 12: this.dev = dev; http://gerrit.ovirt.org/#/c/25409/19/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GraphicsDevice.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GraphicsDevice.java: Line 7: Line 8: private GraphicsDevice() { } Line 9: Line 10: public GraphicsDevice(VmDeviceType type) { Line 11: super(); no need to call explicitely Line 12: setType(VmDeviceGeneralType.GRAPHICS); Line 13: setDevice(type.name().toLowerCase()); Line 14: setId(new VmDeviceId()); Line 15: setAddress(""); http://gerrit.ovirt.org/#/c/25409/19/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1297: CIDR_NOT_NETWORK_ADDRESS=CIDR not represnting a network address.\nplease ensure IP and mask are matching to network IP address. \nexample:\n\tvalid network address: 2.2.0.0/16\n\tinvalid: 2.2.0.1/16 Line 1298: BAD_CIDR_FORMAT=CIDR bad format, expected:\n x.x.x.x/y where:\n x belongs to [0,255] \n y belongs to [0,32] \n both inclusive Line 1299: ACTION_TYPE_FAILED_DEVICE_MUST_BE_SPECIFIED=Cannot ${action} ${type}. Device must be specified. Line 1300: ACTION_TYPE_FAILED_GRAPHIC_TYPE_MUST_BE_SPECIFIED=Cannot ${action} ${type}. Graphics Device Type must be specified. Line 1301: ACTION_TYPE_REMOVE_GRAPHICS_DEV_INVALID_PARAMS=Cannot ${action} ${type}. Graphics device ID or vm/template ID is null. s/vm/VM/g s/template/Template/g -- To view, visit http://gerrit.ovirt.org/25409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9eed1ddb4aa8e8376ba5eff662f1bdf49fda800 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
