Livnat Peer has posted comments on this change. Change subject: engine: Added audit log to update network (#846241) ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java Line 465: NETWORK_ADD_NETWORK_FAILED(943), Line 466: NETWORK_REMOVE_NETWORK(944), Line 467: NETWORK_REMOVE_NETWORK_FAILED(945), Line 468: NETWORK_UPDATE_NETWORK(1111), Line 469: NETWORK_UPDATE_NETWORK_FAILED(1112), Moti - good catch. There is a reason the audit log are orders by there ordinal and not by association. please add the constant where they should be by their ordinal number. Please note that you added 1112 in the wrong place to start with - please fix that as well when submitting a second revision. Line 470: NETWORK_ATTACH_NETWORK_TO_VDS_GROUP(946), Line 471: NETWORK_ATTACH_NETWORK_TO_VDS_GROUP_FAILED(947), Line 472: NETWORK_DETACH_NETWORK_TO_VDS_GROUP(948), Line 473: NETWORK_DETACH_NETWORK_TO_VDS_GROUP_FAILED(949), -- To view, visit http://gerrit.ovirt.org/7219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5743f143c596c1ea57e2a45c54324dbd04876d70 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
