Michael Pasternak has posted comments on this change.
Change subject: restapi: Fix lun mapping for add lun-disk
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapper.java
Line 76: if (model.isSetLogicalUnits()) {
Line 77: LogicalUnit logicalUnit = model.getLogicalUnits().get(0);
Line 78: entity.setLUN_id(logicalUnit.getId());
Line 79: ArrayList<storage_server_connections> connections = new
ArrayList<storage_server_connections>();
Line 80: connections.add(map(logicalUnit, null));
1. this is actually direct-lun impl. how come it does not exist yet?, can you
please verify this with mkublin?
2. about xml representations, i'd go with option #1 as it will allow us
creating disks on luns from different storages
Line 81: entity.setLunConnections(connections);
Line 82: }
Line 83: if (model.isSetType()) {
Line 84: StorageType storageType =
StorageType.fromValue(model.getType());
--
To view, visit http://gerrit.ovirt.org/7206
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e1299265f4c24b4212b57924eb2c4389411c5a4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
