Juan Hernandez has posted comments on this change. Change subject: core: fixing pom to include apache commons-lang. ......................................................................
Patch Set 1: Looks good to me, but someone else must approve In Maven sub projects don't inherit dependencies from parent projects. In addition in this case the commons-lang artifact is not in the "dependencies" section, but in the "denpendenciesManagement" section. This section is used to avoid having to specify properties of dependencies in all the child projects: the version is specified once in the parent and then all child projects just have to specify the group and artifact ids. So you did exactly what is needed. -- To view, visit http://gerrit.ovirt.org/7228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29de43c643be8cd0bc367c487f2e1d5c50b41e74 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
