Liron Aravot has posted comments on this change. Change subject: core: Upload only the DC diskless VMs/Templates to OVF stores ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/35943/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAO.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAO.java: Line 94: public void remove(Guid id, boolean removePermissions); Line 95: Line 96: /** Line 97: * Retrieves all the ids of the vms and templates that have no attached disks matching the provided criteria. Line 98: * @param storagePoolId the storage pool id of the vms/templates > Please use formatter Done Line 99: * @param shareableDisks check for attached shareable disks Line 100: */ Line 101: public List<Guid> getVmAndTemplatesIdsWithoutAttachedImageDisks(Guid storagePoolId, boolean shareableDisks); Line 102: http://gerrit.ovirt.org/#/c/35943/2/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDAOTest.java: Line 209: } Line 210: Line 211: private void verifyVmWithNoDisksForDc(List<Guid> vmBaseWithNoDisks, Guid vmId, Guid storagePoolId) { Line 212: assertTrue(vmBaseWithNoDisks.contains(vmId)); Line 213: assertEquals(storagePoolId, dbFacade.getVmDao().get(vmId).getStoragePoolId()); > You should also check if the VM fetched with "dbFacade.getVmDao().get(vmId) Done Line 214: } Line 215: Line 216: private void verifyTemplateWithNoDisksForDc(List<Guid> vmBaseWithNoDisks, Guid templateId, Guid storagePoolId) { Line 217: assertTrue(vmBaseWithNoDisks.contains(templateId)); Line 214: } Line 215: Line 216: private void verifyTemplateWithNoDisksForDc(List<Guid> vmBaseWithNoDisks, Guid templateId, Guid storagePoolId) { Line 217: assertTrue(vmBaseWithNoDisks.contains(templateId)); Line 218: assertEquals(storagePoolId, dbFacade.getVmTemplateDao().get(templateId).getStoragePoolId()); > You should also check if the Template fetched with "dbFacade.getVmTemplateD Done Line 219: } Line 220: Line 221: @Test Line 222: public void getVmAndTemplatesIdsWithoutAttachedImageDi×›sks() { -- To view, visit http://gerrit.ovirt.org/35943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51689cdf0479548c8c4be1267d478fcb8f89de0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
