Yaniv Dary has posted comments on this change. Change subject: packaging: replaced execExternalCmd with execCmd (#844667) ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... File packaging/ovirt-engine-dwh-setup.py Line 85: Line 86: # Try/Except so we'll be able to return to our current directory Line 87: currDir = os.getcwd() Line 88: try: Line 89: cmd = "sh ./%s" % EXEC_UPGRADE_DB No need to run this with sh, since it's a bash script. Line 90: cmd = [ Line 91: cmd, Line 92: "-s", db_dict["host"], Line 93: "-p", db_dict["port"], Line 95: "-d", db_dict["name"], Line 96: "-l", "/var/log/ovirt-engine/%s" % dbLogFilename, Line 97: ] Line 98: os.chdir(PATH_DB_SCRIPTS) Line 99: output, rc = utils.execCmd(cmdList=cmd, failOnError=True, msg="Error while trying to upgrade ovirt_engine_history DB") No sure this is implemented in common utils. Line 100: except: Line 101: os.chdir(currDir) Line 102: raise Line 103: -- To view, visit http://gerrit.ovirt.org/7250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12458bd73d6806048a3f627b57005192ab627be1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
