Allon Mureinik has uploaded a new change for review. Change subject: core: EnumUtilsTest: Strictly adhere to JUnit spec ......................................................................
core: EnumUtilsTest: Strictly adhere to JUnit spec Renamed a non-test inner class that ends with the word "Test" so that it won't be mistakenly interpreted as a test by some JUnit runners and removed some redundant "throws" clauses. Change-Id: I95cb0d6f98dc955d5c4133e59e9d2c4c1047a0da Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/EnumUtilsTest.java 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/7251/1 diff --git a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/EnumUtilsTest.java b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/EnumUtilsTest.java index 1e8e2bc..e9a7156 100644 --- a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/EnumUtilsTest.java +++ b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/EnumUtilsTest.java @@ -13,7 +13,7 @@ public class EnumUtilsTest { - protected enum EnumForTest { + protected enum EnumForTesting { ENUM1, ENUM2 } @@ -23,13 +23,13 @@ } @Test - public void nameOrNullForNull() throws Exception { - assertNull(EnumUtils.<EnumForTest>nameOrNull(null)); + public void nameOrNullForNull() { + assertNull(EnumUtils.<EnumForTesting>nameOrNull(null)); } @Test - public void nameOrNullForEnum() throws Exception { - assertEquals(EnumForTest.ENUM1.name(), EnumUtils.nameOrNull(EnumForTest.ENUM1)); + public void nameOrNullForEnum() { + assertEquals(EnumForTesting.ENUM1.name(), EnumUtils.nameOrNull(EnumForTesting.ENUM1)); } @Test @@ -39,14 +39,14 @@ @Test public void testEnumCollectionToStringList() { - List<EnumForTest> enumCollection = new ArrayList<EnumForTest>(); - enumCollection.add(EnumForTest.ENUM1); - enumCollection.add(EnumForTest.ENUM2); + List<EnumForTesting> enumCollection = new ArrayList<EnumForTesting>(); + enumCollection.add(EnumForTesting.ENUM1); + enumCollection.add(EnumForTesting.ENUM2); List<String> stringList = EnumUtils.enumCollectionToStringList(enumCollection); assertNotNull(stringList); assertEquals(2, stringList.size()); - assertTrue(stringList.contains(EnumForTest.ENUM1.name())); - assertTrue(stringList.contains(EnumForTest.ENUM2.name())); + assertTrue(stringList.contains(EnumForTesting.ENUM1.name())); + assertTrue(stringList.contains(EnumForTesting.ENUM2.name())); } } -- To view, visit http://gerrit.ovirt.org/7251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I95cb0d6f98dc955d5c4133e59e9d2c4c1047a0da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
