Martin Sivák has posted comments on this change. Change subject: don't use vdsm backend when there is not valid vol or imgUUID ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/36051/4/ovirt_hosted_engine_ha/agent/hosted_engine.py File ovirt_hosted_engine_ha/agent/hosted_engine.py: Line 422: config.LOCKSPACE_VOLUME_UUID), Line 423: ).dump() Line 424: } Line 425: # check if we have all the needed config params needed for vdsm api Line 426: if set(('', None, 'None')) & set(storage_params.values()): I see what it does, but I feel it is not readable enough.. can I propose something like: if any(v in ('None', None, '') for v in storage_params.values()): Line 427: storage_params = { Line 428: 'sd_uuid': sd_uuid, Line 429: 'dom_type': dom_type Line 430: } -- To view, visit http://gerrit.ovirt.org/36051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcd181d260f4f20676a4124b899575b42935753c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Artyom Lukianov <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
