Alexander Wels has uploaded a new change for review. Change subject: userportal,webadmin: Custom dropdown chrome ......................................................................
userportal,webadmin: Custom dropdown chrome - The height in the custom drop downs in chrome was too small, this patches fixes that issue Change-Id: I71b3cf9ef250647c18e08cccc8c83c21f7474477 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1173660 Signed-off-by: Alexander Wels <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/34/36134/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java index 5da8861..95bc78e 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java @@ -1,5 +1,7 @@ package org.ovirt.engine.ui.common.widget.editor; +import java.util.Collection; + import com.google.gwt.dom.client.Style; import com.google.gwt.dom.client.Style.Overflow; import com.google.gwt.dom.client.Style.Unit; @@ -22,8 +24,6 @@ import com.google.gwt.user.client.ui.TextBox; import com.google.gwt.user.client.ui.TextBoxBase; import com.google.gwt.user.client.ui.Widget; - -import java.util.Collection; /** * Base SuggestBox widget that adapts to UiCommon list model items. @@ -134,10 +134,12 @@ return suggestionDisplay.getSuggestionMenu(); } + @Override public void setValue(T value) { setValue(value, false); } + @Override public void setValue(T value, boolean fireEvents) { this.value = value; render(value, fireEvents); @@ -196,13 +198,13 @@ Element popupPanelElement = getPopupPanel().getWidget().getElement(); Style popupPanel = popupPanelElement.getStyle(); popupPanel.setDisplay(Style.Display.BLOCK); - popupPanel.setHeight(100, Unit.PCT); + popupPanel.setProperty("height", "auto"); //$NON-NLS-1$ //$NON-NLS-2$ popupPanel.setPropertyPx("maxHeight", maxSuggestionPanelHeightInPx); //$NON-NLS-1$ popupPanel.setOverflowY(Overflow.SCROLL); popupPanel.setOverflowX(Overflow.HIDDEN); Style suggestPopupContentStyle = popupPanelElement.getParentElement().getStyle(); - suggestPopupContentStyle.setHeight(100, Unit.PCT); + suggestPopupContentStyle.setProperty("height", "auto"); //$NON-NLS-1$ //$NON-NLS-2$ suggestPopupContentStyle.setPropertyPx("maxHeight", maxSuggestionPanelHeightInPx); //$NON-NLS-1$ suggestPopupContentStyle.setOverflowX(Overflow.HIDDEN); suggestPopupContentStyle.setProperty("display", "table"); //$NON-NLS-1$ //$NON-NLS-2$ -- To view, visit http://gerrit.ovirt.org/36134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I71b3cf9ef250647c18e08cccc8c83c21f7474477 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
