Sahina Bose has posted comments on this change. Change subject: gluster: VDS Command - Gluster vol snapshot create ......................................................................
Patch Set 14: (4 comments) http://gerrit.ovirt.org/#/c/23212/14/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 1548: Line 1549: @Override Line 1550: public OneUuidReturnForXmlRpc glusterSnapshotCreate(String volumeName, String snapshotName, String description, boolean force) { Line 1551: JsonRpcRequest request = Line 1552: new RequestBuilder("GlusterSnapshot.create").withOptionalParameter("volumeName", volumeName) is volumeName optional parameter? Line 1553: .withParameter("snapName", snapshotName) Line 1554: .withParameter("description", description) Line 1555: .withParameter("force", force) Line 1556: .build(); http://gerrit.ovirt.org/#/c/23212/14/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java: Line 833: @DefaultStringValue("Cannot get list of images in ISO domain. " + Line 834: "Please check that the storage domain status is Active") Line 835: String GetIsoListError(); Line 836: Line 837: @DefaultStringValue("Gluster Snapshot Exception") "Error in executing gluster snapshot command" instead? Line 838: String GlusterSnapshotException(); Line 839: Line 840: @DefaultStringValue("Gluster snapshot create failed") Line 841: String GlusterSnapshotCreateFailedException(); Line 836: Line 837: @DefaultStringValue("Gluster Snapshot Exception") Line 838: String GlusterSnapshotException(); Line 839: Line 840: @DefaultStringValue("Gluster snapshot create failed") "Failed to create snapshot for gluster volume" Line 841: String GlusterSnapshotCreateFailedException(); http://gerrit.ovirt.org/#/c/23212/14/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties: Line 381: GlusterHostIsNotPartOfCluster = Host is not part of the cluster Line 382: GlusterVolumeRebalanceStatusFailedException=Failed to get gluster volume rebalance status Line 383: GlusterVolumeRemoveBrickStatusFailed=Failed to get status of gluster volume remove bricks Line 384: GlusterSnapshotException=Gluster Snapshot Exception Line 385: GlusterSnapshotCreateFailedException=Gluster snapshot create failed same error message suggestions as previous file -- To view, visit http://gerrit.ovirt.org/23212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib610f49c3b6c5aa108ce6fef0291cd9693429197 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
