Asaf Shakarchi has uploaded a new change for review.

Change subject: webadmin: path count shows incorrect number on luns>targets 
(#838912)
......................................................................

webadmin: path count shows incorrect number on luns>targets (#838912)

https://bugzilla.redhat.com/838912

When logging into a new target the new LUNs are merged
into a cached list which contains the previouse loaded LUNs,

If the cached list already contains a new LUN which has been
updated with new details, the new LUN won't be merged,

This patch updates existing cached LUNs in case there is a new version
available after target login.

Change-Id: I7f700b411b119310b554a17f8447fc51c554d1ff
Signed-off-by: Asaf Shakarchi <[email protected]>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
1 file changed, 15 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/60/7260/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
index 8b86ca0..94c35c1 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
@@ -404,9 +404,22 @@
                     targets.add(item);
                 }
 
-                if (Linq.FirstOrDefault(item.getLuns(), new 
Linq.LunPredicate(lun)) == null)
-                {
+                LunModel currLun = Linq.FirstOrDefault(item.getLuns(), new 
Linq.LunPredicate(lun));
+                if (currLun == null) {
                     item.getLuns().add(lun);
+                } else {
+                    currLun.setLunId(lun.getLunId());
+                    currLun.setVendorId(lun.getVendorId());
+                    currLun.setProductId(lun.getProductId());
+                    currLun.setSerial(lun.getSerial());
+                    currLun.setMultipathing(lun.getMultipathing());
+                    currLun.setTargets((ArrayList) targets);
+                    currLun.setSize(lun.getSize());
+                    currLun.setIsAccessible(lun.getIsAccessible());
+                    currLun.setStatus(lun.getStatus());
+                    currLun.setIsIncluded(lun.getIsIncluded());
+                    currLun.setIsSelected(lun.getIsSelected());
+                    currLun.setEntity(lun.getEntity());
                 }
             }
 


--
To view, visit http://gerrit.ovirt.org/7260
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f700b411b119310b554a17f8447fc51c554d1ff
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to