Eli Mesika has posted comments on this change.
Change subject: core: when iso domain is inactive we still go to the cache
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java
Line 39: } else {
Line 40:
addCanDoActionMessage(VdcBllMessages.VAR__ACTION__EJECT_CD);
Line 41: }
Line 42:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_VM_STATUS_ILLEGAL);
Line 43: } else if
((VmRunHandler.getInstance().findActiveISODomain(getVm().getstorage_pool_id())
== null) && !StringUtils.isEmpty(mCdImagePath)) {
Done
Line 44:
addCanDoActionMessage(VdcBllMessages.VAR__ACTION__CHANGE_CD);
Line 45:
addCanDoActionMessage(VdcBllMessages.VM_CANNOT_WITHOUT_ACTIVE_STORAGE_DOMAIN_ISO);
Line 46: setSucceeded(false);
Line 47: retValue = false;
--
To view, visit http://gerrit.ovirt.org/5184
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d24c94c4dd630c5a76ae1fee65bee257b5e40f0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
